-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emptied config files #539
fix: emptied config files #539
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@anmolyadav-dev please fix the errors. |
I commented 2 cypress test cases and added some data in config file so it gets build without any issue |
@ashmit-coder all issues are resolved |
@anmolyadav-dev , @thulieblack will provide you with the information we need inplace of the old one, so as to extend the issue and tackle it in a single pr. |
@ashmit-coder OK !! will do it |
Hi @anmolyadav-dev, please don't delete any files rather, replace the information with the details:
Open the Call for speakers for Singapore, link to the CFP https://apidays.typeform.com/apidayscfp?typeform-source=www.apidays.global
Leave APIdays there as it is and remove Gravitee and Postman
|
@thulieblack i should remove ticket buying link and other old links right |
Leave the ticket section. For the other links, just comment them out or replace them with the above links. Or you can let me know what you need |
@thulieblack For Singapore , Munich and Lagos we don't have images, address and map link and i am leaving old address and map links for Paris and London |
Just comment out the links and add the venues for now. |
@thulieblack what do i fill in cfp-data.config currently i did this |
CFP data Singapore on the 15th - 16th of April. CFP open date is from today until 23rd of February |
please commit your changes @anmolyadav-dev so I can review properly |
I don't understand what you mean by globally, you mean on the homepage? |
@thulieblack Yes I mean on homepage . In homepage it still have gravitee and postman |
yes it should be added there as well |
What about other venues like singapore and others. Will there be other sponsors for those . |
For those, I'll work on a follow-up issue to add the rest of the details and rewrite some descriptions |
@thulieblack i am done with adding sponsor logos |
@thulieblack can you do a final review |
@anmolyadav-dev could you try and fix the build fail. |
secondly please remove the changes in your package-lock json file |
@ashmit-coder build is working fine and i removed package files from commit |
please loook into this as, if the preview wont work, then after the merge, the entire website will be down. |
@ashmit-coder with my latest commit it is building fine . can you see if it is not showing preview for latest commit or previous commit |
/ptal |
@AceTheCreator @ashmit-coder @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please do verify the details on your end @thulieblack .
Looking at the Netlify report, the build failed Unless its because of the current branch @AceTheCreator please confirm |
Good work @anmolyadav-dev ! |
Description
Related Issues
Resolves #535