Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emptied config files #539

Merged
merged 23 commits into from
Feb 10, 2025

Conversation

anmolyadav-dev
Copy link
Contributor

Description

  • Emptied the config files values and kept the keys as it is
  • removed multiple keys for similar objects
  • in editions.json -> added 2024 site link

Related Issues

Resolves #535

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a09843b
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67a9d4c3185a2e00086738e7
😎 Deploy Preview https://deploy-preview-539--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anmolyadav-dev anmolyadav-dev changed the title fix:Emptied config files fix: emptied config files Jan 23, 2025
@ashmit-coder
Copy link
Collaborator

@anmolyadav-dev please fix the errors.

@anmolyadav-dev
Copy link
Contributor Author

I commented 2 cypress test cases and added some data in config file so it gets build without any issue

@anmolyadav-dev
Copy link
Contributor Author

@ashmit-coder all issues are resolved

@ashmit-coder
Copy link
Collaborator

@anmolyadav-dev , @thulieblack will provide you with the information we need inplace of the old one, so as to extend the issue and tackle it in a single pr.

@anmolyadav-dev
Copy link
Contributor Author

@ashmit-coder OK !! will do it

@thulieblack
Copy link
Member

Hi @anmolyadav-dev, please don't delete any files rather, replace the information with the details:

  1. Conference Venues

  • Singapore on the 15th - 16th of April.
  • Munich on the 2nd - 3rd of July.
  • Lagos, Nigeria, on the 18th - 19th of July.
  • London on the 22nd - 24th of September.
  • AsyncAPI Online Conference on the 29th of October
  • Paris on the 9th -11th of December.
  1. CFP

Open the Call for speakers for Singapore, link to the CFP https://apidays.typeform.com/apidayscfp?typeform-source=www.apidays.global

  1. Sponsors

Leave APIdays there as it is and remove Gravitee and Postman

  1. Leave the resources hub there as well

@anmolyadav-dev
Copy link
Contributor Author

@thulieblack i should remove ticket buying link and other old links right

@thulieblack
Copy link
Member

Leave the ticket section. For the other links, just comment them out or replace them with the above links. Or you can let me know what you need

@anmolyadav-dev
Copy link
Contributor Author

@thulieblack For Singapore , Munich and Lagos we don't have images, address and map link and i am leaving old address and map links for Paris and London

@thulieblack
Copy link
Member

Just comment out the links and add the venues for now.

@anmolyadav-dev
Copy link
Contributor Author

i have replaced old Venues with new ones . Just haven't added any image to Singapore , Munich and Lagos, they have same image as london

Screenshot from 2025-01-29 18-00-06
Screenshot from 2025-01-29 17-59-53
Screenshot from 2025-01-29 17-59-47

@anmolyadav-dev
Copy link
Contributor Author

@thulieblack what do i fill in cfp-data.config currently i did this
image

@thulieblack
Copy link
Member

CFP data Singapore on the 15th - 16th of April.

CFP open date is from today until 23rd of February

@thulieblack
Copy link
Member

please commit your changes @anmolyadav-dev so I can review properly

@thulieblack
Copy link
Member

I don't understand what you mean by globally, you mean on the homepage?

@anmolyadav-dev
Copy link
Contributor Author

anmolyadav-dev commented Jan 30, 2025

@thulieblack Yes I mean on homepage . In homepage it still have gravitee and postman

@thulieblack
Copy link
Member

yes it should be added there as well

@anmolyadav-dev
Copy link
Contributor Author

What about other venues like singapore and others. Will there be other sponsors for those .

@thulieblack
Copy link
Member

For those, I'll work on a follow-up issue to add the rest of the details and rewrite some descriptions

@anmolyadav-dev
Copy link
Contributor Author

@thulieblack i am done with adding sponsor logos

@anmolyadav-dev
Copy link
Contributor Author

@thulieblack can you do a final review

@ashmit-coder
Copy link
Collaborator

@thulieblack can you do a final review

@anmolyadav-dev could you try and fix the build fail.

@ashmit-coder
Copy link
Collaborator

secondly please remove the changes in your package-lock json file

@anmolyadav-dev
Copy link
Contributor Author

@ashmit-coder build is working fine and i removed package files from commit

@ashmit-coder
Copy link
Collaborator

@anmolyadav-dev

image

please loook into this as, if the preview wont work, then after the merge, the entire website will be down.

@anmolyadav-dev
Copy link
Contributor Author

@ashmit-coder with my latest commit it is building fine .
Screenshot from 2025-02-04 20-46-36

can you see if it is not showing preview for latest commit or previous commit

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @ashmit-coder @Mayaleeeee Please take a look at this PR. Thanks! 👋

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please do verify the details on your end @thulieblack .

@thulieblack
Copy link
Member

Looking at the Netlify report, the build failed
image

Unless its because of the current branch @AceTheCreator please confirm

@ashmit-coder ashmit-coder merged commit f17c4ef into asyncapi:master Feb 10, 2025
13 checks passed
@ashmit-coder
Copy link
Collaborator

Good work @anmolyadav-dev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Updating the config data files, to be empty
5 participants